1
   2
   3
   4
   5
   6
   7
   8
   9
  10
  11
  12
  13
  14
  15
  16
  17
  18
  19
  20
  21
  22
  23
  24
  25
  26
  27
  28
  29
  30
  31
  32
  33
  34
  35
  36
  37
  38
  39
  40
  41
  42
  43
  44
  45
  46
  47
  48
  49
  50
  51
  52
  53
  54
  55
  56
  57
  58
  59
  60
  61
  62
  63
  64
  65
  66
  67
  68
  69
  70
  71
  72
  73
  74
  75
  76
  77
  78
  79
  80
  81
  82
  83
  84
  85
  86
  87
  88
  89
  90
  91
  92
  93
  94
  95
  96
  97
  98
  99
 100
 101
 102
 103
 104
 105
 106
 107
 108
 109
 110
 111
 112
 113
 114
 115
 116
 117
 118
 119
 120
 121
 122
 123
 124
 125
 126
 127
 128
 129
 130
 131
 132
 133
 134
 135
 136
 137
 138
 139
 140
 141
 142
 143
 144
 145
 146
 147
 148
 149
 150
 151
 152
 153
 154
 155
 156
 157
 158
 159
 160
 161
 162
 163
 164
 165
 166
 167
 168
 169
 170
 171
 172
 173
 174
 175
 176
 177
 178
 179
 180
 181
 182
 183
 184
 185
 186
 187
 188
 189
 190
 191
 192
 193
 194
 195
 196
 197
 198
 199
 200
 201
 202
 203
 204
 205
 206
 207
 208
 209
 210
 211
 212
 213
 214
 215
 216
 217
 218
 219
 220
 221
 222
 223
 224
 225
 226
 227
 228
 229
 230
 231
 232
 233
 234
 235
 236
 237
 238
 239
 240
 241
 242
 243
 244
 245
 246
 247
 248
 249
 250
 251
 252
 253
 254
 255
 256
 257
 258
 259
 260
 261
 262
 263
 264
 265
 266
 267
 268
 269
 270
 271
 272
 273
 274
 275
 276
 277
 278
 279
 280
 281
 282
 283
 284
 285
 286
 287
 288
 289
 290
 291
 292
 293
 294
 295
 296
 297
 298
 299
 300
 301
 302
 303
 304
 305
 306
 307
 308
 309
 310
 311
 312
 313
 314
 315
 316
 317
 318
 319
 320
 321
 322
 323
 324
 325
 326
 327
 328
 329
 330
 331
 332
 333
 334
 335
 336
 337
 338
 339
 340
 341
 342
 343
 344
 345
 346
 347
 348
 349
 350
 351
 352
 353
 354
 355
 356
 357
 358
 359
 360
 361
 362
 363
 364
 365
 366
 367
 368
 369
 370
 371
 372
 373
 374
 375
 376
 377
 378
 379
 380
 381
 382
 383
 384
 385
 386
 387
 388
 389
 390
 391
 392
 393
 394
 395
 396
 397
 398
 399
 400
 401
 402
 403
 404
 405
 406
 407
 408
 409
 410
 411
 412
 413
 414
 415
 416
 417
 418
 419
 420
 421
 422
 423
 424
 425
 426
 427
 428
 429
 430
 431
 432
 433
 434
 435
 436
 437
 438
 439
 440
 441
 442
 443
 444
 445
 446
 447
 448
 449
 450
 451
 452
 453
 454
 455
 456
 457
 458
 459
 460
 461
 462
 463
 464
 465
 466
 467
 468
 469
 470
 471
 472
 473
 474
 475
 476
 477
 478
 479
 480
 481
 482
 483
 484
 485
 486
 487
 488
 489
 490
 491
 492
 493
 494
 495
 496
 497
 498
 499
 500
 501
 502
 503
 504
 505
 506
 507
 508
 509
 510
 511
 512
 513
 514
 515
 516
 517
 518
 519
 520
 521
 522
 523
 524
 525
 526
 527
 528
 529
 530
 531
 532
 533
 534
 535
 536
 537
 538
 539
 540
 541
 542
 543
 544
 545
 546
 547
 548
 549
 550
 551
 552
 553
 554
 555
 556
 557
 558
 559
 560
 561
 562
 563
 564
 565
 566
 567
 568
 569
 570
 571
 572
 573
 574
 575
 576
 577
 578
 579
 580
 581
 582
 583
 584
 585
 586
 587
 588
 589
 590
 591
 592
 593
 594
 595
 596
 597
 598
 599
 600
 601
 602
 603
 604
 605
 606
 607
 608
 609
 610
 611
 612
 613
 614
 615
 616
 617
 618
 619
 620
 621
 622
 623
 624
 625
 626
 627
 628
 629
 630
 631
 632
 633
 634
 635
 636
 637
 638
 639
 640
 641
 642
 643
 644
 645
 646
 647
 648
 649
 650
 651
 652
 653
 654
 655
 656
 657
 658
 659
 660
 661
 662
 663
 664
 665
 666
 667
 668
 669
 670
 671
 672
 673
 674
 675
 676
 677
 678
 679
 680
 681
 682
 683
 684
 685
 686
 687
 688
 689
 690
 691
 692
 693
 694
 695
 696
 697
 698
 699
 700
 701
 702
 703
 704
 705
 706
 707
 708
 709
 710
 711
 712
 713
 714
 715
 716
 717
 718
 719
 720
 721
 722
 723
 724
 725
 726
 727
 728
 729
 730
 731
 732
 733
 734
 735
 736
 737
 738
 739
 740
 741
 742
 743
 744
 745
 746
 747
 748
 749
 750
 751
 752
 753
 754
 755
 756
 757
 758
 759
 760
 761
 762
 763
 764
 765
 766
 767
 768
 769
 770
 771
 772
 773
 774
 775
 776
 777
 778
 779
 780
 781
 782
 783
 784
 785
 786
 787
 788
 789
 790
 791
 792
 793
 794
 795
 796
 797
 798
 799
 800
 801
 802
 803
 804
 805
 806
 807
 808
 809
 810
 811
 812
 813
 814
 815
 816
 817
 818
 819
 820
 821
 822
 823
 824
 825
 826
 827
 828
 829
 830
 831
 832
 833
 834
 835
 836
 837
 838
 839
 840
 841
 842
 843
 844
 845
 846
 847
 848
 849
 850
 851
 852
 853
 854
 855
 856
 857
 858
 859
 860
 861
 862
 863
 864
 865
 866
 867
 868
 869
 870
 871
 872
 873
 874
 875
 876
 877
 878
 879
 880
 881
 882
 883
 884
 885
 886
 887
 888
 889
 890
 891
 892
 893
 894
 895
 896
 897
 898
 899
 900
 901
 902
 903
 904
 905
 906
 907
 908
 909
 910
 911
 912
 913
 914
 915
 916
 917
 918
 919
 920
 921
 922
 923
 924
 925
 926
 927
 928
 929
 930
 931
 932
 933
 934
 935
 936
 937
 938
 939
 940
 941
 942
 943
 944
 945
 946
 947
 948
 949
 950
 951
 952
 953
 954
 955
 956
 957
 958
 959
 960
 961
 962
 963
 964
 965
 966
 967
 968
 969
 970
 971
 972
 973
 974
 975
 976
 977
 978
 979
 980
 981
 982
 983
 984
 985
 986
 987
 988
 989
 990
 991
 992
 993
 994
 995
 996
 997
 998
 999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
use ast::*;
use binjs_shared::{IdentifierName, VisitMe};

use std::collections::{HashMap, HashSet};

use itertools::Itertools;

type EnterResult = Result<VisitMe<()>, ScopeError>;
type ExitResult<T> = Result<Option<T>, ScopeError>;

#[derive(Debug)]
pub enum ScopeError {
    /// While analyzing scopes, we exit a binding identifier but there is no binding kind.
    MissingBindingKind,

    /// This name is defined twice in the same scope
    NameIsDefinedTwiceInTheSameScope {
        /// If `true`, the name is a const lexical name.
        const_lexical: bool,
        name: IdentifierName,
    },
}

#[derive(Debug, PartialEq, Eq)]
enum BindingKind {
    Var,
    NonConstLexical,
    ConstLexical,

    // Positional parameter.
    //   * Simple parameter
    //   * Default parameter without destructuring
    PositionalParam {
        // The depth of the path when entering PositionalParameter.
        // Used to check matching binding when leaving.
        depth: usize,

        // The perameter index.
        index: u32,
    },

    // Rest parameter.
    // This is pushed onto the stack whenever it's inside parameter, for the
    // following 2 reasons.
    //   * To handle rest parameter binding correctly,
    //     which doesn't have any enclosing structure
    //   * To mark it's inside parameter, see is_positional_parameter and
    //     is_destructuring_parameter
    RestParam,

    // Destructuring parameter, including default parameter with destructuring.
    DestructuringParam {
        // The depth of the path when entering destructuring parameter,
        // which is ObjectBinding or ArrayBinding directly under parameter
        // or default parameter.
        // Used to check matching binding when leaving.
        depth: usize,
    },
    Bound,
}

struct VarAndLexNames {
    var_names: HashSet<IdentifierName>,
    non_const_lexical_names: HashSet<IdentifierName>,
    const_lexical_names: HashSet<IdentifierName>,
}

enum ParamKind {
    Positional { index: u32, name: IdentifierName },
    Destructuring { name: IdentifierName },
    Rest { name: IdentifierName },
}

pub struct AnnotationVisitor {
    // The following are stacks.
    var_names_stack: Vec<HashSet<IdentifierName>>,
    non_const_lexical_names_stack: Vec<HashSet<IdentifierName>>,
    const_lexical_names_stack: Vec<HashSet<IdentifierName>>,
    params_stack: Vec<Vec<ParamKind>>,

    // The current parameter index for each (nested) function, which is used
    // by PositionalParameter.
    // An item (0) is pushed when entering function, and popped when leaving.
    // The item is incremented when leaving parameter.
    param_indices_stack: Vec<u32>,

    bound_names_stack: Vec<HashSet<IdentifierName>>,
    binding_kind_stack: Vec<BindingKind>,
    apparent_direct_eval_stack: Vec<bool>,
    function_expression_name_stack: Vec<Option<BindingIdentifier>>,

    // 'true' if the free name has already crossed a function boundary
    // 'false' until then.
    free_names_in_block_stack: Vec<HashMap<IdentifierName, bool>>,

    /// A shared reference to `this`.
    this_reference: IdentifierName,
    this_declaration: IdentifierName,
}
impl AnnotationVisitor {
    pub fn new() -> Self {
        let this_reference = IdentifierName::from_str("this");
        Self {
            var_names_stack: Vec::new(),
            non_const_lexical_names_stack: Vec::new(),
            const_lexical_names_stack: Vec::new(),
            params_stack: Vec::new(),
            param_indices_stack: Vec::new(),
            bound_names_stack: Vec::new(),
            binding_kind_stack: Vec::new(),
            apparent_direct_eval_stack: Vec::new(),
            function_expression_name_stack: Vec::new(),
            free_names_in_block_stack: Vec::new(),
            this_reference: this_reference.clone(),
            this_declaration: this_reference,
        }
    }
    fn pop_captured_names(
        &mut self,
        bindings: &[&HashSet<IdentifierName>],
    ) -> HashSet<IdentifierName> {
        let mut captured_names = HashSet::new();
        let my_free_names = self.free_names_in_block_stack.last_mut().unwrap();
        for binding in bindings {
            for name in *binding {
                if let Some(cross_function) = my_free_names.remove(name) {
                    // Free names across nested function boundaries are closed.
                    debug!(target: "annotating", "found captured name {:?}", name);
                    if cross_function {
                        captured_names.insert(name.clone());
                    }
                }
            }
        }

        captured_names
    }

    fn push_free_names(&mut self) {
        self.free_names_in_block_stack.push(HashMap::new());
    }
    fn pop_free_names(
        &mut self,
        bindings: &[&HashSet<IdentifierName>],
        is_leaving_function_scope: bool,
    ) {
        let mut free_names_in_current_block = self.free_names_in_block_stack.pop().unwrap();
        for (name, old_cross_function) in free_names_in_current_block.drain() {
            let is_bound = bindings
                .iter()
                .find(|container| container.contains(&name))
                .is_some();
            if !is_bound {
                // Propagate free names up to the enclosing scope, for further analysis.
                // Actively propagate the closure flag as we go. It could have been set by
                //   A nested scope: old_cross_function
                //   This scope: is_leaving_function_scope
                //   Or, it could have already been in the parent scope from a sibling block.
                // Or everything together, so we don't forget if the binding was closed over.
                if let Some(parent_free) = self.free_names_in_block_stack.last_mut() {
                    let my_contribution = old_cross_function || is_leaving_function_scope;
                    parent_free
                        .entry(name)
                        .and_modify(|p| *p = *p || my_contribution)
                        .or_insert(my_contribution);
                }
            }
        }
    }

    fn push_direct_eval(&mut self) {
        // So far, we haven't spotted any direct eval.
        self.apparent_direct_eval_stack.push(false);
    }
    fn pop_direct_eval(&mut self) -> bool {
        let spotted_direct_eval = self.apparent_direct_eval_stack.pop().unwrap();
        if spotted_direct_eval {
            // If we have spotted a direct eval, well, the parents also have
            // a direct eval. Note that we will perform a second pass to
            // remove erroneous direct evals if we find out that name `eval`
            // was actually bound at some point.
            if let Some(parent) = self.apparent_direct_eval_stack.last_mut() {
                *parent = true;
            }
        }
        spotted_direct_eval
    }

    fn push_block_scope(&mut self, _path: &WalkPath) {
        self.non_const_lexical_names_stack.push(HashSet::new());
        self.const_lexical_names_stack.push(HashSet::new());
        self.push_free_names();
        self.push_direct_eval();
    }
    fn pop_block_scope(&mut self, path: &WalkPath) -> AssertedBlockScope {
        debug!(target: "annotating", "pop_block_scope at {:?}", path);
        let non_const_lexical_names = self.non_const_lexical_names_stack.pop().unwrap();
        let const_lexical_names = self.const_lexical_names_stack.pop().unwrap();

        debug!(target: "annotating", "pop_non_const_scope lex {:?}", non_const_lexical_names);
        debug!(target: "annotating", "pop_const_scope lex {:?}", const_lexical_names);

        let captured_names =
            self.pop_captured_names(&[&non_const_lexical_names, &const_lexical_names]);
        self.pop_free_names(
            &[&non_const_lexical_names, &const_lexical_names],
            /* is_leaving_function_scope = */ false,
        );

        let mut declared_names = vec![];
        for name in non_const_lexical_names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            declared_names.push(AssertedDeclaredName {
                name,
                kind: AssertedDeclaredKind::NonConstLexical,
                is_captured,
            })
        }
        for name in const_lexical_names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            declared_names.push(AssertedDeclaredName {
                name,
                kind: AssertedDeclaredKind::ConstLexical,
                is_captured,
            })
        }

        debug_assert_eq!(
            {
                let as_set: HashSet<_> = declared_names.iter().map(|x| &x.name).collect();
                as_set.len()
            },
            declared_names.len(),
            "Duplicate declared names"
        );

        let has_direct_eval = self.pop_direct_eval();
        AssertedBlockScope {
            declared_names,
            has_direct_eval,
        }
    }

    fn push_incomplete_var_scope(&mut self, _path: &WalkPath) {
        self.var_names_stack.push(HashSet::new());
        self.non_const_lexical_names_stack.push(HashSet::new());
        self.const_lexical_names_stack.push(HashSet::new());
    }
    fn push_var_scope(&mut self, path: &WalkPath) {
        debug!(target: "annotating", "push_var_scope at {:?}", path);
        self.push_incomplete_var_scope(path);
        self.push_direct_eval();
        self.push_free_names();
    }
    fn pop_incomplete_var_scope(&mut self, path: &WalkPath) -> Result<VarAndLexNames, ScopeError> {
        debug!(target: "annotating", "pop_incomplete_var_scope at {:?}", path);
        let var_names = self.var_names_stack.pop().unwrap();
        let non_const_lexical_names = self.non_const_lexical_names_stack.pop().unwrap();
        let const_lexical_names = self.const_lexical_names_stack.pop().unwrap();

        debug!(target: "annotating", "pop_incomplete_var_scope var {:?}", var_names);
        debug!(target: "annotating", "pop_incomplete_var_scope non_const {:?}", non_const_lexical_names);
        debug!(target: "annotating", "pop_incomplete_var_scope const {:?}", const_lexical_names);

        // Check that a name isn't defined twice in the same scope.
        for name in var_names.intersection(&non_const_lexical_names) {
            return Err(ScopeError::NameIsDefinedTwiceInTheSameScope {
                const_lexical: false,
                name: name.clone(),
            });
        }
        for name in var_names.intersection(&const_lexical_names) {
            return Err(ScopeError::NameIsDefinedTwiceInTheSameScope {
                const_lexical: true,
                name: name.clone(),
            });
        }
        Ok(VarAndLexNames {
            var_names,
            non_const_lexical_names,
            const_lexical_names,
        })
    }
    fn pop_var_and_lex_declared_names(
        &mut self,
        path: &WalkPath,
    ) -> Result<Vec<AssertedDeclaredName>, ScopeError> {
        let VarAndLexNames {
            var_names,
            non_const_lexical_names,
            const_lexical_names,
        } = self.pop_incomplete_var_scope(path)?;
        let captured_names =
            self.pop_captured_names(&[&var_names, &non_const_lexical_names, &const_lexical_names]);
        self.pop_free_names(
            &[&var_names, &non_const_lexical_names, &const_lexical_names],
            /* is_leaving_function_scope = */ true,
        );

        let mut declared_names = vec![];
        for name in var_names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            declared_names.push(AssertedDeclaredName {
                name,
                kind: AssertedDeclaredKind::Var,
                is_captured,
            })
        }
        for name in non_const_lexical_names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            declared_names.push(AssertedDeclaredName {
                name,
                kind: AssertedDeclaredKind::NonConstLexical,
                is_captured,
            })
        }
        for name in const_lexical_names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            declared_names.push(AssertedDeclaredName {
                name,
                kind: AssertedDeclaredKind::ConstLexical,
                is_captured,
            })
        }

        debug_assert_eq!(
            {
                let as_set: HashSet<_> = declared_names.iter().map(|x| &x.name).collect();
                as_set.len()
            },
            declared_names.len(),
            "Duplicate declared names"
        );

        Ok(declared_names)
    }

    fn pop_var_scope(&mut self, path: &WalkPath) -> Result<AssertedVarScope, ScopeError> {
        let declared_names = self.pop_var_and_lex_declared_names(path)?;
        let has_direct_eval = self.pop_direct_eval();

        Ok(AssertedVarScope {
            declared_names,
            has_direct_eval,
        })
    }
    fn pop_script_global_scope(
        &mut self,
        path: &WalkPath,
    ) -> Result<AssertedScriptGlobalScope, ScopeError> {
        let declared_names = self.pop_var_and_lex_declared_names(path)?;
        let has_direct_eval = self.pop_direct_eval();

        Ok(AssertedScriptGlobalScope {
            declared_names,
            has_direct_eval,
        })
    }

    fn push_this_captured(&mut self) {
        self.push_free_names();
    }
    fn pop_this_captured(&mut self) -> bool {
        let mut this_names = HashSet::new();
        this_names.insert(self.this_declaration.clone());
        let captured_names = self.pop_captured_names(&[&this_names]);
        self.pop_free_names(&[&this_names], /* is_leaving_function_scope = */ false);
        captured_names.contains(&self.this_declaration)
    }

    fn push_function_name_captured(&mut self) {
        self.push_free_names();
    }
    fn pop_function_name_captured(&mut self, name: IdentifierName) -> bool {
        let mut names = HashSet::new();
        names.insert(name.clone());
        let captured_names = self.pop_captured_names(&[&names]);
        self.pop_free_names(&[&names], /* is_leaving_function_scope = */ false);
        captured_names.contains(&name)
    }

    fn push_param_scope(&mut self, _path: &WalkPath) {
        debug!(target: "annotating", "push_param_scope at {:?}", _path);
        self.params_stack.push(vec![]);
        self.param_indices_stack.push(0);
        self.push_free_names();
        self.push_direct_eval();
    }
    fn pop_param_scope(
        &mut self,
        path: &WalkPath,
        parameter_scope: &AssertedParameterScope,
    ) -> Result<AssertedParameterScope, ScopeError> {
        debug!(target: "annotating", "pop_param_scope at {:?}", path);

        fn to_declaration(param: &ParamKind) -> IdentifierName {
            match param {
                ParamKind::Positional { index: _, name } => name.clone(),
                ParamKind::Destructuring { name } => name.clone(),
                ParamKind::Rest { name } => name.clone(),
            }
        };

        let params = self.params_stack.pop().unwrap();
        self.param_indices_stack.pop();
        let names = params.as_slice().into_iter().map(to_declaration).collect();
        let captured_names = self.pop_captured_names(&[&names]);
        self.pop_free_names(&[&names], /* is_leaving_function_scope = */ false);

        // In the case of `function foo(j) {var j;}`, the `var j` is not the true declaration.
        // Remove it from parameters.
        for name in &names {
            if self.var_names_stack.last_mut().unwrap().remove(name) {
                debug!(target: "annotating", "pop_param_scope removing {:?}", name);
            }
        }

        let len = params.len();
        let mut param_names = Vec::with_capacity(len);
        for param in params.into_iter() {
            let is_captured = captured_names.contains(&to_declaration(&param));
            param_names.push(match param {
                ParamKind::Positional { index, name } => {
                    AssertedMaybePositionalParameterName::AssertedPositionalParameterName(Box::new(
                        AssertedPositionalParameterName {
                            index,
                            name,
                            is_captured,
                        },
                    ))
                }
                ParamKind::Destructuring { name } => {
                    AssertedMaybePositionalParameterName::AssertedParameterName(Box::new(
                        AssertedParameterName { name, is_captured },
                    ))
                }
                ParamKind::Rest { name } => {
                    AssertedMaybePositionalParameterName::AssertedRestParameterName(Box::new(
                        AssertedRestParameterName { name, is_captured },
                    ))
                }
            })
        }

        let has_direct_eval = self.pop_direct_eval();

        debug_assert_eq!(
            {
                let as_set: HashSet<_> = param_names
                    .iter()
                    .map(|x| {
                        use ast::AssertedMaybePositionalParameterName::*;
                        match *x {
                            AssertedPositionalParameterName(ref b) => &b.name,
                            AssertedParameterName(ref b) => &b.name,
                            AssertedRestParameterName(ref b) => &b.name,
                            BinASTStolen => panic!(),
                        }
                    })
                    .collect();
                as_set.len()
            },
            len,
            "Duplicate param names"
        );

        Ok(AssertedParameterScope {
            param_names,
            has_direct_eval,
            is_simple_parameter_list: parameter_scope.is_simple_parameter_list,
        })
    }
    fn push_bound_names_scope(&mut self, _path: &WalkPath) {
        debug!(target: "annotating", "push_bound_names_scope at {:?}", _path);
        self.bound_names_stack.push(HashSet::new());
        self.push_free_names();
        self.push_direct_eval();
    }
    fn pop_bound_names_scope(&mut self, path: &WalkPath) -> AssertedBoundNamesScope {
        debug!(target: "annotating", "pop_bound_names_scope at {:?}", path);

        let names = self.bound_names_stack.pop().unwrap();
        let captured_names = self.pop_captured_names(&[&names]);
        self.pop_free_names(&[&names], /* is_leaving_function_scope = */ false);

        let mut bound_names = Vec::with_capacity(names.len());
        // The order of the bound names is not defined per spec.
        // Since `names` is HashSet which doesn't keep the order of appearance,
        // we sort it alphabetically.
        for name in names.into_iter().sorted() {
            let is_captured = captured_names.contains(&name);
            bound_names.push(AssertedBoundName { name, is_captured })
        }

        debug_assert_eq!(
            {
                let as_set: HashSet<_> = bound_names.iter().map(|x| &x.name).collect();
                as_set.len()
            },
            bound_names.len(),
            "Duplicate declared names"
        );

        let has_direct_eval = self.pop_direct_eval();
        AssertedBoundNamesScope {
            bound_names,
            has_direct_eval,
        }
    }
    fn function_expression_name(&self) -> Option<IdentifierName> {
        match self.function_expression_name_stack.last().unwrap() {
            Some(identifier) => Some(identifier.name.clone()),
            _ => None,
        }
    }
    fn push_function_expression_name(&mut self, name: Option<BindingIdentifier>) {
        self.function_expression_name_stack.push(name);
    }
    fn pop_function_expression_name(&mut self) {
        self.function_expression_name_stack.pop();
    }

    fn exit_lazy_or_eager_function_declaration<T>(
        &mut self,
        path: &WalkPath,
        name: &BindingIdentifier,
    ) -> ExitResult<T> {
        // If a name declaration was specified, remove it from `unknown`.
        let name = name.name.clone();

        // Var scope is already committed in exit_function_or_method_contents.
        // The function's name is not actually bound in the function; the outer var binding is used.
        // Anything we do from this point affects the scope outside the function.

        // 1. If the declaration is at the toplevel, the name is declared as a `var`.
        // 2. If the declaration is in a function's toplevel block, the name is declared as a `var`.
        // 3. Otherwise, the name is declared as a `let`.
        debug!(target: "annotating", "exit_lazy_or_eager_function_declaration sees {:?} at {:?}", name, path.get(0));
        match path.get(0).expect("Impossible AST walk") {
            &WalkPathItem {
                field: ASTField::Statements,
                interface: ASTNode::Script,
            }
            | &WalkPathItem {
                field: ASTField::Statements,
                interface: ASTNode::Module,
            } => {
                // Case 1.
                debug!(target: "annotating", "exit_lazy_or_eager_function_declaration says it's a var (case 1)");
                self.var_names_stack.last_mut().unwrap().insert(name);
            }
            &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::GetterContents,
            }
            | &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::SetterContents,
            }
            | &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::ArrowExpressionContentsWithFunctionBody,
            }
            | &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::ArrowExpressionContentsWithExpression,
            }
            | &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::FunctionExpressionContents,
            }
            | &WalkPathItem {
                field: ASTField::Body,
                interface: ASTNode::FunctionOrMethodContents,
            } => {
                // Case 2.
                debug!(target: "annotating", "exit_eager_function_declaration says it's a var (case 2)");
                self.var_names_stack.last_mut().unwrap().insert(name);
            }
            _ => {
                // Case 3.
                debug!(target: "annotating", "exit_lazy_or_eager_function_declaration says it's a non const lexical (case 3)");
                self.non_const_lexical_names_stack
                    .last_mut()
                    .unwrap()
                    .insert(name);
            }
        }
        Ok(None)
    }
}

fn is_positional_parameter(visitor: &AnnotationVisitor, path: &WalkPath) -> bool {
    match visitor.binding_kind_stack.last() {
        // BindingKind::RestParam should be on the binding kind stack whenever
        // it's inside parameter, even if it's setter which cannot have rest.
        Some(BindingKind::RestParam) => {}
        _ => {
            return false;
        }
    };
    match path.get(0) {
        Some(&WalkPathItem {
            interface: ASTNode::BindingWithInitializer,
            field: ASTField::Binding,
        }) => match path.get(1) {
            Some(&WalkPathItem {
                interface: ASTNode::SetterContents,
                field: ASTField::Param,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::FormalParameters,
                field: ASTField::Items,
            }) => true,
            _ => false,
        },
        Some(&WalkPathItem {
            interface: ASTNode::SetterContents,
            field: ASTField::Param,
        })
        | Some(&WalkPathItem {
            interface: ASTNode::FormalParameters,
            field: ASTField::Items,
        }) => true,
        _ => false,
    }
}
fn maybe_enter_positional_parameter(visitor: &mut AnnotationVisitor, path: &WalkPath) {
    if !is_positional_parameter(visitor, path) {
        return;
    }

    // `is_positional_parameter` above already checked this is inside function.
    // `param_indices_stack` should contain an item for the function.
    let i = *visitor.param_indices_stack.last().unwrap();
    visitor
        .binding_kind_stack
        .push(BindingKind::PositionalParam {
            depth: path.len(),
            index: i,
        });
}
fn maybe_exit_positional_parameter(visitor: &mut AnnotationVisitor, path: &WalkPath) {
    if visitor.param_indices_stack.is_empty() {
        return;
    }

    // We can unwrap because `param_indices_stack` is not empty.
    let i = *visitor.param_indices_stack.last().unwrap();
    match visitor.binding_kind_stack.last() {
        Some(BindingKind::PositionalParam { depth, index })
            if *depth == path.len() && *index == i => {}
        _ => {
            return;
        }
    }

    *(visitor.param_indices_stack.last_mut().unwrap()) = i + 1;
    visitor.binding_kind_stack.pop();
}

fn is_destructuring_parameter(visitor: &AnnotationVisitor, path: &WalkPath) -> bool {
    match visitor.binding_kind_stack.last() {
        // See is_positional_parameter.
        Some(BindingKind::RestParam) => {}
        _ => {
            return false;
        }
    };
    match path.get(0) {
        Some(&WalkPathItem {
            interface: ASTNode::BindingWithInitializer,
            field: ASTField::Binding,
        }) => match path.get(1) {
            Some(&WalkPathItem {
                interface: ASTNode::SetterContents,
                field: ASTField::Param,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::FormalParameters,
                field: ASTField::Items,
            }) => true,
            _ => false,
        },
        Some(&WalkPathItem {
            interface: ASTNode::SetterContents,
            field: ASTField::Param,
        })
        | Some(&WalkPathItem {
            interface: ASTNode::FormalParameters,
            field: ASTField::Items,
        }) => true,
        _ => false,
    }
}
fn maybe_enter_destructuring_parameter(visitor: &mut AnnotationVisitor, path: &WalkPath) {
    if !is_destructuring_parameter(visitor, path) {
        return;
    }

    visitor
        .binding_kind_stack
        .push(BindingKind::DestructuringParam { depth: path.len() });
}
fn maybe_exit_destructuring_parameter(visitor: &mut AnnotationVisitor, path: &WalkPath) {
    match visitor.binding_kind_stack.last() {
        Some(BindingKind::DestructuringParam { depth }) if *depth == path.len() => {}
        _ => {
            return;
        }
    }

    *(visitor.param_indices_stack.last_mut().unwrap()) += 1;
    visitor.binding_kind_stack.pop();
}

impl Visitor<ScopeError> for AnnotationVisitor {
    // Identifiers

    fn exit_call_expression(
        &mut self,
        _path: &WalkPath,
        node: &mut CallExpression,
    ) -> ExitResult<CallExpression> {
        if let ExpressionOrSuper::IdentifierExpression(ref id) = node.callee {
            if id.name == "eval" {
                *self.apparent_direct_eval_stack.last_mut().unwrap() = true;
            }
        }
        Ok(None)
    }

    fn exit_identifier_expression(
        &mut self,
        _path: &WalkPath,
        node: &mut IdentifierExpression,
    ) -> ExitResult<IdentifierExpression> {
        debug!(target: "annotating", "exit_identifier_expression {:?} at {:?}", node.name, _path);
        let names = self.free_names_in_block_stack.last_mut().unwrap();
        if !names.contains_key(&node.name) {
            names.insert(node.name.clone(), false);
        }
        Ok(None)
    }
    fn exit_this_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut ThisExpression,
    ) -> ExitResult<ThisExpression> {
        debug!(target: "annotating", "exit_this_expression at {:?}", _path);
        let names = self.free_names_in_block_stack.last_mut().unwrap();
        if !names.contains_key(&self.this_reference) {
            names.insert(self.this_reference.clone(), false);
        }
        Ok(None)
    }

    fn exit_assignment_target_identifier(
        &mut self,
        _path: &WalkPath,
        node: &mut AssignmentTargetIdentifier,
    ) -> ExitResult<AssignmentTargetIdentifier> {
        let names = self.free_names_in_block_stack.last_mut().unwrap();
        if !names.contains_key(&node.name) {
            names.insert(node.name.clone(), false);
        }
        Ok(None)
    }

    fn enter_binding_identifier(
        &mut self,
        path: &WalkPath,
        _node: &mut BindingIdentifier,
    ) -> EnterResult {
        maybe_enter_positional_parameter(self, path);
        Ok(VisitMe::HoldThis(()))
    }

    fn exit_binding_identifier(
        &mut self,
        path: &WalkPath,
        node: &mut BindingIdentifier,
    ) -> ExitResult<BindingIdentifier> {
        match path.get(0) {
            Some(&WalkPathItem {
                interface: ASTNode::EagerFunctionDeclaration,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::LazyFunctionDeclaration,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::EagerFunctionExpression,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::LazyFunctionExpression,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::EagerMethod,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::LazyMethod,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::EagerGetter,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::LazyGetter,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::EagerSetter,
                field: ASTField::Name,
            })
            | Some(&WalkPathItem {
                interface: ASTNode::LazySetter,
                field: ASTField::Name,
            }) => {
                // Function names are special.
                // They are handled in the respective `exit_*` methods.
                return Ok(None);
            }
            _ => {}
        }
        debug!(target: "annotating", "exit_binding_identifier – marking {name:?} as {kind:?} at {path:?}",
                name = node.name,
                kind = self.binding_kind_stack.last(),
                path = path);
        if self.binding_kind_stack.last().is_none() {
            return Err(ScopeError::MissingBindingKind);
        }
        let declaration = node.name.clone();
        match *self.binding_kind_stack.last().unwrap() {
            BindingKind::Var => {
                self.var_names_stack.last_mut().unwrap().insert(declaration);
            }
            BindingKind::NonConstLexical => {
                self.non_const_lexical_names_stack
                    .last_mut()
                    .unwrap()
                    .insert(declaration);
            }
            BindingKind::ConstLexical => {
                self.const_lexical_names_stack
                    .last_mut()
                    .unwrap()
                    .insert(declaration);
            }
            BindingKind::PositionalParam { depth: _, index } => {
                self.params_stack
                    .last_mut()
                    .unwrap()
                    .push(ParamKind::Positional {
                        index,
                        name: declaration,
                    });
            }
            BindingKind::RestParam => {
                self.params_stack
                    .last_mut()
                    .unwrap()
                    .push(ParamKind::Rest { name: declaration });
            }
            BindingKind::DestructuringParam { depth: _ } => {
                self.params_stack
                    .last_mut()
                    .unwrap()
                    .push(ParamKind::Destructuring { name: declaration });
            }
            BindingKind::Bound => {
                self.bound_names_stack
                    .last_mut()
                    .unwrap()
                    .insert(declaration);
            }
        }
        maybe_exit_positional_parameter(self, path);
        Ok(None)
    }

    // Blocks

    fn enter_block(&mut self, path: &WalkPath, _node: &mut Block) -> EnterResult {
        self.push_block_scope(path);
        Ok(VisitMe::HoldThis(()))
    }

    fn exit_block(&mut self, path: &WalkPath, node: &mut Block) -> ExitResult<Block> {
        node.scope = self.pop_block_scope(path);
        Ok(None)
    }

    fn enter_script(&mut self, path: &WalkPath, _node: &mut Script) -> EnterResult {
        self.push_var_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_script(&mut self, path: &WalkPath, node: &mut Script) -> ExitResult<Script> {
        node.scope = self.pop_script_global_scope(path)?;
        Ok(None)
    }

    fn enter_module(&mut self, path: &WalkPath, _node: &mut Module) -> EnterResult {
        self.push_var_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_module(&mut self, path: &WalkPath, node: &mut Module) -> ExitResult<Module> {
        node.scope = self.pop_var_scope(path)?;
        Ok(None)
    }

    // Try/Catch
    fn enter_catch_clause(&mut self, path: &WalkPath, _node: &mut CatchClause) -> EnterResult {
        self.binding_kind_stack.push(BindingKind::Bound);

        // We need to differentiate between
        // `var ex; try { ... } catch(ex) { ... }` (both instances of `ex` are distinct)
        // and
        // `try { ... } catch(ex) { var ex; ... }` (both instances of `ex` are the same)
        // so we introduce a var scope in `catch(ex)`, as if `catch(ex) { ... }` was
        // a function.

        self.push_incomplete_var_scope(path);
        self.push_bound_names_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_catch_clause(
        &mut self,
        path: &WalkPath,
        node: &mut CatchClause,
    ) -> ExitResult<CatchClause> {
        assert_matches!(self.binding_kind_stack.pop(), Some(BindingKind::Bound));
        node.binding_scope = self.pop_bound_names_scope(path);
        let var_scope = self.pop_incomplete_var_scope(path)?;

        assert_eq!(var_scope.non_const_lexical_names.len(), 0, "The implicit scope of a catch should not contain lexically declared names. This requires an actual block.");
        assert_eq!(var_scope.const_lexical_names.len(), 0, "The implicit scope of a catch should not contain lexically declared names. This requires an actual block.");

        // Propagate any var_declared_names.
        for name in var_scope.var_names.into_iter() {
            debug!(target: "annotating", "exit_catch_clause: reinserting {:?}", name);
            self.var_names_stack.last_mut().unwrap().insert(name);
        }

        Ok(None)
    }

    // Explicit variable declarations

    fn enter_for_in_of_binding(
        &mut self,
        _path: &WalkPath,
        node: &mut ForInOfBinding,
    ) -> EnterResult {
        let kind = match node.kind {
            VariableDeclarationKind::Let => BindingKind::NonConstLexical,
            VariableDeclarationKind::Const => BindingKind::ConstLexical,
            VariableDeclarationKind::Var => BindingKind::Var,
        };
        self.binding_kind_stack.push(kind);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_for_in_of_binding(
        &mut self,
        _path: &WalkPath,
        node: &mut ForInOfBinding,
    ) -> ExitResult<ForInOfBinding> {
        let kind = match node.kind {
            VariableDeclarationKind::Let => BindingKind::NonConstLexical,
            VariableDeclarationKind::Const => BindingKind::ConstLexical,
            VariableDeclarationKind::Var => BindingKind::Var,
        };
        assert_eq!(self.binding_kind_stack.pop().unwrap(), kind);
        Ok(None)
    }

    fn enter_variable_declaration(
        &mut self,
        _path: &WalkPath,
        node: &mut VariableDeclaration,
    ) -> EnterResult {
        let kind = match node.kind {
            VariableDeclarationKind::Let => BindingKind::NonConstLexical,
            VariableDeclarationKind::Const => BindingKind::ConstLexical,
            VariableDeclarationKind::Var => BindingKind::Var,
        };
        self.binding_kind_stack.push(kind);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_variable_declaration(
        &mut self,
        _path: &WalkPath,
        node: &mut VariableDeclaration,
    ) -> ExitResult<VariableDeclaration> {
        let kind = match node.kind {
            VariableDeclarationKind::Let => BindingKind::NonConstLexical,
            VariableDeclarationKind::Const => BindingKind::ConstLexical,
            VariableDeclarationKind::Var => BindingKind::Var,
        };
        assert_eq!(self.binding_kind_stack.pop().unwrap(), kind);
        Ok(None)
    }

    // Functions, methods, arguments.
    fn enter_setter_contents(
        &mut self,
        path: &WalkPath,
        _node: &mut SetterContents,
    ) -> EnterResult {
        // Just like FormalParameters, push BindingKind::RestParam to mark
        // it's inside parameter.
        // See enter_formal_parameters and is_positional_parameter for more
        // details.
        self.binding_kind_stack.push(BindingKind::RestParam);

        self.push_param_scope(path);
        self.push_var_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_setter_contents(
        &mut self,
        path: &WalkPath,
        node: &mut SetterContents,
    ) -> ExitResult<SetterContents> {
        assert_matches!(self.binding_kind_stack.pop(), Some(BindingKind::RestParam));
        // Commit parameter scope and var scope.
        node.parameter_scope = self.pop_param_scope(path, &node.parameter_scope)?;
        node.body_scope = self.pop_var_scope(path)?;

        Ok(None)
    }

    fn enter_getter_contents(
        &mut self,
        path: &WalkPath,
        _node: &mut GetterContents,
    ) -> EnterResult {
        self.push_var_scope(path);
        Ok(VisitMe::HoldThis(()))
    }

    fn exit_getter_contents(
        &mut self,
        path: &WalkPath,
        node: &mut GetterContents,
    ) -> ExitResult<GetterContents> {
        node.body_scope = self.pop_var_scope(path)?;

        Ok(None)
    }

    fn enter_function_or_method_contents(
        &mut self,
        path: &WalkPath,
        _node: &mut FunctionOrMethodContents,
    ) -> EnterResult {
        self.push_var_scope(path);
        self.push_param_scope(path);
        self.push_this_captured();
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_function_or_method_contents(
        &mut self,
        path: &WalkPath,
        node: &mut FunctionOrMethodContents,
    ) -> ExitResult<FunctionOrMethodContents> {
        debug!(target: "annotating", "exit_function_or_method_contents at {:?}", path);
        node.is_this_captured = self.pop_this_captured();

        // Commit parameter scope and var scope.
        node.parameter_scope = self.pop_param_scope(path, &node.parameter_scope)?;
        node.body_scope = self.pop_var_scope(path)?;

        Ok(None)
    }

    fn enter_arrow_expression_contents_with_function_body(
        &mut self,
        path: &WalkPath,
        _node: &mut ArrowExpressionContentsWithFunctionBody,
    ) -> EnterResult {
        self.push_var_scope(path);
        self.push_param_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_arrow_expression_contents_with_function_body(
        &mut self,
        path: &WalkPath,
        node: &mut ArrowExpressionContentsWithFunctionBody,
    ) -> ExitResult<ArrowExpressionContentsWithFunctionBody> {
        // Commit parameter scope and var scope.
        node.parameter_scope = self.pop_param_scope(path, &node.parameter_scope)?;
        node.body_scope = self.pop_var_scope(path)?;

        Ok(None)
    }
    fn enter_arrow_expression_contents_with_expression(
        &mut self,
        path: &WalkPath,
        _node: &mut ArrowExpressionContentsWithExpression,
    ) -> EnterResult {
        self.push_var_scope(path);
        self.push_param_scope(path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_arrow_expression_contents_with_expression(
        &mut self,
        path: &WalkPath,
        node: &mut ArrowExpressionContentsWithExpression,
    ) -> ExitResult<ArrowExpressionContentsWithExpression> {
        // Commit parameter scope and var scope.
        node.parameter_scope = self.pop_param_scope(path, &node.parameter_scope)?;
        node.body_scope = self.pop_var_scope(path)?;

        Ok(None)
    }

    fn enter_function_expression_contents(
        &mut self,
        path: &WalkPath,
        _node: &mut FunctionExpressionContents,
    ) -> EnterResult {
        // For parity, push function name in its proper place as the outermost binding.
        // See comment below in exit_function_expression_contents for more context.
        if let Some(_) = self.function_expression_name() {
            self.push_function_name_captured();
        }
        self.push_var_scope(path);
        self.push_param_scope(path);
        self.push_this_captured();
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_function_expression_contents(
        &mut self,
        path: &WalkPath,
        node: &mut FunctionExpressionContents,
    ) -> ExitResult<FunctionExpressionContents> {
        node.is_this_captured = self.pop_this_captured();

        node.parameter_scope = self.pop_param_scope(path, &node.parameter_scope)?;
        node.body_scope = self.pop_var_scope(path)?;

        // Wait to pop the function name until after we handle vars and params.
        // If there's a shadowing var, the var is captured, not the function name.
        // Since there's only one stack for used names, and it expects things in scope-order,
        // we risk getting confused and claiming the wrong binding was closed over.
        if let Some(ref name) = self.function_expression_name() {
            node.is_function_name_captured = self.pop_function_name_captured(name.clone());
        } else {
            node.is_function_name_captured = false;
        }
        Ok(None)
    }

    fn enter_eager_function_expression(
        &mut self,
        _path: &WalkPath,
        node: &mut EagerFunctionExpression,
    ) -> EnterResult {
        self.push_function_expression_name(node.name.clone());
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_function_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerFunctionExpression,
    ) -> ExitResult<EagerFunctionExpression> {
        self.pop_function_expression_name();
        Ok(None)
    }

    fn enter_lazy_function_expression(
        &mut self,
        _path: &WalkPath,
        node: &mut LazyFunctionExpression,
    ) -> EnterResult {
        self.push_function_expression_name(node.name.clone());
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_lazy_function_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut LazyFunctionExpression,
    ) -> ExitResult<LazyFunctionExpression> {
        self.pop_function_expression_name();
        Ok(None)
    }

    fn exit_eager_function_declaration(
        &mut self,
        path: &WalkPath,
        node: &mut EagerFunctionDeclaration,
    ) -> ExitResult<EagerFunctionDeclaration> {
        debug!(target: "annotating", "exit_eager_function_declaration {:?} at {:?}", node.name.name, path);
        self.exit_lazy_or_eager_function_declaration(path, &node.name)
    }

    fn exit_lazy_function_declaration(
        &mut self,
        path: &WalkPath,
        node: &mut LazyFunctionDeclaration,
    ) -> ExitResult<LazyFunctionDeclaration> {
        self.exit_lazy_or_eager_function_declaration(path, &node.name)
    }

    fn enter_formal_parameters(
        &mut self,
        _path: &WalkPath,
        _node: &mut FormalParameters,
    ) -> EnterResult {
        // Handle rest parameter field here.  Other parameters are handled in
        // BindingIdentifier/ObjectBinding/ArrayBinding.
        self.binding_kind_stack.push(BindingKind::RestParam);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_formal_parameters(
        &mut self,
        _path: &WalkPath,
        _node: &mut FormalParameters,
    ) -> ExitResult<FormalParameters> {
        assert_matches!(self.binding_kind_stack.pop(), Some(BindingKind::RestParam));
        Ok(None)
    }

    fn enter_object_binding(&mut self, path: &WalkPath, _node: &mut ObjectBinding) -> EnterResult {
        maybe_enter_destructuring_parameter(self, path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_object_binding(
        &mut self,
        path: &WalkPath,
        _node: &mut ObjectBinding,
    ) -> ExitResult<ObjectBinding> {
        maybe_exit_destructuring_parameter(self, path);
        Ok(None)
    }

    fn enter_array_binding(&mut self, path: &WalkPath, _node: &mut ArrayBinding) -> EnterResult {
        maybe_enter_destructuring_parameter(self, path);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_array_binding(
        &mut self,
        path: &WalkPath,
        _node: &mut ArrayBinding,
    ) -> ExitResult<ArrayBinding> {
        maybe_exit_destructuring_parameter(self, path);
        Ok(None)
    }
}

/// Perform a second pass to cleanup incorrect instances of `eval`.
struct EvalCleanupAnnotator {
    /// `true` if name `eval` was bound at this level or higher in the tree.
    eval_bindings: Vec<bool>,
}

impl Visitor<ScopeError> for EvalCleanupAnnotator {
    // FIXME: Anything that has a scope (including CatchClause and its invisible scope) should push an `eval_bindings`.
    // on entering, pop it on exit.
    fn enter_eager_function_declaration(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerFunctionDeclaration,
    ) -> EnterResult {
        // By default, adopt parent's behavior.
        // If necessary, reading the scope information will amend it.
        let has_eval_binding = *self.eval_bindings.last().unwrap();
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_function_declaration(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerFunctionDeclaration,
    ) -> ExitResult<EagerFunctionDeclaration> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_function_expression(
        &mut self,
        _path: &WalkPath,
        node: &mut EagerFunctionExpression,
    ) -> EnterResult {
        // By default, adopt parent's behavior.
        // Don't forget that the internal name of the function may mask `eval`.
        let mut has_eval_binding = *self.eval_bindings.last().unwrap();
        if let Some(ref name) = node.name {
            has_eval_binding = has_eval_binding || name.name == "eval";
        }
        self.eval_bindings.push(has_eval_binding);
        // If necessary, reading the scope information will amend it.
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_function_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerFunctionExpression,
    ) -> ExitResult<EagerFunctionExpression> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_arrow_expression_with_function_body(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerArrowExpressionWithFunctionBody,
    ) -> EnterResult {
        // By default, adopt parent's behavior.
        // If necessary, reading the scope information will amend it.
        let has_eval_binding = *self.eval_bindings.last().unwrap();
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_arrow_expression_with_function_body(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerArrowExpressionWithFunctionBody,
    ) -> ExitResult<EagerArrowExpressionWithFunctionBody> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_arrow_expression_with_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerArrowExpressionWithExpression,
    ) -> EnterResult {
        // By default, adopt parent's behavior.
        // If necessary, reading the scope information will amend it.
        let has_eval_binding = *self.eval_bindings.last().unwrap();
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_arrow_expression_with_expression(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerArrowExpressionWithExpression,
    ) -> ExitResult<EagerArrowExpressionWithExpression> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_getter(&mut self, _path: &WalkPath, node: &mut EagerGetter) -> EnterResult {
        // Don't forget that the internal name of the getter may mask `eval`.
        let mut has_eval_binding = *self.eval_bindings.last().unwrap();
        if let PropertyName::LiteralPropertyName(ref name) = node.name {
            has_eval_binding = has_eval_binding || name.value == "eval";
        }
        // If necessary, reading the scope information will amend it.
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_getter(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerGetter,
    ) -> ExitResult<EagerGetter> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_setter(&mut self, _path: &WalkPath, node: &mut EagerSetter) -> EnterResult {
        // Don't forget that the internal name of the setter may mask `eval`.
        let mut has_eval_binding = *self.eval_bindings.last().unwrap();
        if let PropertyName::LiteralPropertyName(ref name) = node.name {
            has_eval_binding = has_eval_binding || name.value == "eval";
        }
        // If necessary, reading the scope information will amend it.
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_setter(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerSetter,
    ) -> ExitResult<EagerSetter> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_eager_method(&mut self, _path: &WalkPath, node: &mut EagerMethod) -> EnterResult {
        // Don't forget that the internal name of the method may mask `eval`.
        let mut has_eval_binding = *self.eval_bindings.last().unwrap();
        if let PropertyName::LiteralPropertyName(ref name) = node.name {
            has_eval_binding = has_eval_binding || name.value == "eval";
        }
        // If necessary, reading the scope information will amend it.
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_eager_method(
        &mut self,
        _path: &WalkPath,
        _node: &mut EagerMethod,
    ) -> ExitResult<EagerMethod> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }
    fn enter_catch_clause(&mut self, _path: &WalkPath, node: &mut CatchClause) -> EnterResult {
        // Don't forget that the implicitly declared variable may mask `eval`.
        let mut has_eval_binding = *self.eval_bindings.last().unwrap();
        match node.binding {
            Binding::BindingIdentifier(ref binding) => {
                has_eval_binding = has_eval_binding || binding.name == "eval";
            }
            _ => unimplemented!(), // FIXME: Patterns may also mask `eval`.
        }
        self.eval_bindings.push(has_eval_binding);
        Ok(VisitMe::HoldThis(()))
    }
    fn exit_catch_clause(
        &mut self,
        _path: &WalkPath,
        _node: &mut CatchClause,
    ) -> ExitResult<CatchClause> {
        self.eval_bindings.pop().unwrap();
        Ok(None)
    }

    // Update scopes themselves.
    fn exit_asserted_block_scope(
        &mut self,
        _path: &WalkPath,
        node: &mut AssertedBlockScope,
    ) -> ExitResult<AssertedBlockScope> {
        if node
            .declared_names
            .iter()
            .find(|e| e.name == "eval")
            .is_some()
        {
            *self.eval_bindings.last_mut().unwrap() = true;
        }
        if *self.eval_bindings.last().unwrap() {
            node.has_direct_eval = false;
        }
        Ok(None)
    }
    fn exit_asserted_var_scope(
        &mut self,
        _path: &WalkPath,
        node: &mut AssertedVarScope,
    ) -> ExitResult<AssertedVarScope> {
        if node
            .declared_names
            .iter()
            .find(|e| e.name == "eval")
            .is_some()
        {
            *self.eval_bindings.last_mut().unwrap() = true;
        }
        if *self.eval_bindings.last().unwrap() {
            node.has_direct_eval = false;
        }
        Ok(None)
    }
    fn exit_asserted_parameter_scope(
        &mut self,
        _path: &WalkPath,
        node: &mut AssertedParameterScope,
    ) -> ExitResult<AssertedParameterScope> {
        if node
            .param_names
            .iter()
            .find(|param| match param {
                AssertedMaybePositionalParameterName::AssertedPositionalParameterName(ref p) => {
                    p.name == "eval"
                }
                AssertedMaybePositionalParameterName::AssertedParameterName(ref p) => {
                    p.name == "eval"
                }
                AssertedMaybePositionalParameterName::AssertedRestParameterName(ref p) => {
                    p.name == "eval"
                }
                AssertedMaybePositionalParameterName::BinASTStolen => panic!(),
            })
            .is_some()
        {
            *self.eval_bindings.last_mut().unwrap() = true;
        }
        if *self.eval_bindings.last().unwrap() {
            node.has_direct_eval = false;
        }
        Ok(None)
    }
}

impl AnnotationVisitor {
    pub fn annotate_script(&mut self, script: &mut Script) -> Result<(), ScopeError> {
        // Annotate.

        // At this stage, we may have false positives for `hasDirectEval`.
        script.walk(&mut WalkPath::new(), self)?;

        // Cleanup false positives for `hasDirectEval`.
        let mut cleanup = EvalCleanupAnnotator {
            eval_bindings: vec![false],
        };
        script.walk(&mut WalkPath::new(), &mut cleanup)?;
        Ok(())
    }
}